Skip to content

Replace ocispec.MediaTypeImageManifest with manifest.MediaType#3900

Closed
yeahdongcn wants to merge 1 commit intocontainerd:masterfrom
yeahdongcn:master
Closed

Replace ocispec.MediaTypeImageManifest with manifest.MediaType#3900
yeahdongcn wants to merge 1 commit intocontainerd:masterfrom
yeahdongcn:master

Conversation

@yeahdongcn
Copy link
Copy Markdown

@yeahdongcn yeahdongcn commented Dec 18, 2019

Import a tar with manifest.json, ctr image ls returns incorrect TYPE.

REF                              TYPE                                       DIGEST                                                                  SIZE      PLATFORMS   LABELS 
docker.io/library/myimage:latest application/vnd.oci.image.manifest.v1+json sha256:663a45ec27ca42bd4ad37eab55a7ad96db3ee5d7ad5c6dc5bbec958b9e63ad53 745.9 KiB linux/amd64 -   

Signed-off-by: Xiaodong Ye [email protected]

@yeahdongcn yeahdongcn marked this pull request as ready for review December 18, 2019 12:13
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Dec 18, 2019

Build succeeded.

@yeahdongcn
Copy link
Copy Markdown
Author

Travis CI build failure seems to be unrelated.

@crosbymichael
Copy link
Copy Markdown
Member

@yeahdongcn can you please rebase this change on master to pick up the fixes for CI? Sorry about that.

@yeahdongcn
Copy link
Copy Markdown
Author

@yeahdongcn can you please rebase this change on master to pick up the fixes for CI? Sorry about that.

No problem, thanks.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Dec 20, 2019

Build succeeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants