Added memory and cpu metrics for cgroupv2#3893
Merged
estesp merged 9 commits intocontainerd:masterfrom Dec 19, 2019
Merged
Conversation
Signed-off-by: bpopovschi <[email protected]>
Contributor
Author
|
@AkihiroSuda PTAL |
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3893 +/- ##
==========================================
+ Coverage 42.33% 42.47% +0.13%
==========================================
Files 130 130
Lines 14703 14716 +13
==========================================
+ Hits 6225 6251 +26
+ Misses 7552 7544 -8
+ Partials 926 921 -5
Continue to review full report at Codecov.
|
Signed-off-by: bpopovschi <[email protected]>
Contributor
Author
|
@crosbymichael PTAL |
AkihiroSuda
requested changes
Dec 16, 2019
|
Build succeeded.
|
Signed-off-by: bpopovschi <[email protected]>
|
Build succeeded.
|
AkihiroSuda
reviewed
Dec 16, 2019
AkihiroSuda
reviewed
Dec 16, 2019
AkihiroSuda
reviewed
Dec 16, 2019
Member
|
Almost looks good, but please check units and typos carefully, thanks |
Member
|
btw, could you use your full name for |
Signed-off-by: Boris Popovschi <[email protected]>
Contributor
Author
|
@AkihiroSuda Sure, done. |
|
Build succeeded.
|
Member
|
Looks like you still need to edit the first 3 commits with full name? |
Contributor
Author
|
@cpuguy83 Let's leave it for the next time, don't think it's so mandatory. |
AkihiroSuda
reviewed
Dec 17, 2019
Signed-off-by: Boris Popovschi <[email protected]>
AkihiroSuda
approved these changes
Dec 17, 2019
|
Build succeeded.
|
AkihiroSuda
reviewed
Dec 17, 2019
Signed-off-by: Boris Popovschi <[email protected]>
|
Build succeeded.
|
AkihiroSuda
reviewed
Dec 17, 2019
Signed-off-by: Boris Popovschi <[email protected]>
|
Build succeeded.
|
AkihiroSuda
reviewed
Dec 17, 2019
AkihiroSuda
reviewed
Dec 17, 2019
Signed-off-by: Boris Popovschi <[email protected]>
AkihiroSuda
reviewed
Dec 17, 2019
AkihiroSuda
reviewed
Dec 17, 2019
|
Build succeeded.
|
Signed-off-by: Boris Popovschi <[email protected]>
|
Build succeeded.
|
AkihiroSuda
approved these changes
Dec 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #3726
Added memory and cpu metrics for cgroupv2
Signed-off-by: bpopovschi [email protected]