Skip to content

test: Do SynchronousDelete cleanup before testing ImageIsUnpacked#3832

Merged
estesp merged 1 commit intocontainerd:masterfrom
darfux:improve_image_is_unpacked_test
Nov 18, 2019
Merged

test: Do SynchronousDelete cleanup before testing ImageIsUnpacked#3832
estesp merged 1 commit intocontainerd:masterfrom
darfux:improve_image_is_unpacked_test

Conversation

@darfux
Copy link
Copy Markdown
Contributor

@darfux darfux commented Nov 17, 2019

Simply delete the image will not clean up the snapshots.

Signed-off-by: Li Yuxuan [email protected]

Simply delete the image will not clean up the snapshots.

Signed-off-by: Li Yuxuan <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Nov 17, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 17, 2019

Codecov Report

Merging #3832 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3832   +/-   ##
=======================================
  Coverage   41.98%   41.98%           
=======================================
  Files         130      130           
  Lines       14577    14577           
=======================================
  Hits         6120     6120           
  Misses       7543     7543           
  Partials      914      914
Flag Coverage Δ
#linux 45.42% <ø> (ø) ⬆️
#windows 36.94% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec661e8...19f7f3c. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants