Skip to content

Fix dependency in BUILDING.md#3814

Merged
fuweid merged 1 commit intocontainerd:masterfrom
rll2396:bug-3813
Nov 11, 2019
Merged

Fix dependency in BUILDING.md#3814
fuweid merged 1 commit intocontainerd:masterfrom
rll2396:bug-3813

Conversation

@rll2396
Copy link
Copy Markdown
Contributor

@rll2396 rll2396 commented Nov 9, 2019

btrfs/ioctl.h is now included in libbtrfs-dev instead of btrfs-tools.
Update BUILDING.md Dockerfile to install the correct dependency.

Resolves: #3813

Signed-off-by: Reid Li [email protected]

btrfs/ioctl.h is now included in libbtrfs-dev instead of btrfs-tools.
Update BUILDING.md Dockerfile to install the correct dependency.

Resolves: containerd#3813

Signed-off-by: Reid Li <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Nov 9, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 9, 2019

Codecov Report

Merging #3814 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3814      +/-   ##
==========================================
- Coverage   41.99%   41.98%   -0.02%     
==========================================
  Files         130      130              
  Lines       14577    14577              
==========================================
- Hits         6122     6120       -2     
- Misses       7542     7543       +1     
- Partials      913      914       +1
Flag Coverage Δ
#linux 45.42% <ø> (-0.02%) ⬇️
#windows 36.94% <ø> (ø) ⬆️
Impacted Files Coverage Δ
snapshots/btrfs/btrfs.go 57.39% <0%> (-0.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40ac923...a647407. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 01047ed into containerd:master Nov 11, 2019
@rll2396 rll2396 deleted the bug-3813 branch November 11, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependency missing after following Docker build instructions

5 participants