Skip to content

[release/1.2 backport] Update to Golang 1.12.13#3809

Merged
mxpv merged 2 commits intocontainerd:release/1.2from
thaJeztah:1.2_backport_bump_golang_1.12.13
Nov 10, 2019
Merged

[release/1.2 backport] Update to Golang 1.12.13#3809
mxpv merged 2 commits intocontainerd:release/1.2from
thaJeztah:1.2_backport_bump_golang_1.12.13

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

backport of #3806 for the 1.2 release branch
some small conflicts due to travis having diverged a bit on master, but trivial to resolve

go1.12.13 (released 2019/10/31) fixes an issue on macOS 10.15 Catalina
where the non-notarized installer and binaries were being rejected by
Gatekeeper. Only macOS users who hit this issue need to update.

This reverts commit 435e05f.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
go1.12.13 (released 2019/10/31) fixes an issue on macOS 10.15 Catalina
where the non-notarized installer and binaries were being rejected by
Gatekeeper. Only macOS users who hit this issue need to update.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 15669a1)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Copy Markdown
Member Author

opened as draft, because the change wasn't merged yet on master

@thaJeztah
Copy link
Copy Markdown
Member Author

master was merged; moving out of draft

@thaJeztah thaJeztah marked this pull request as ready for review November 8, 2019 19:49
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 8, 2019

Codecov Report

Merging #3809 into release/1.2 will increase coverage by 3.18%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.2    #3809      +/-   ##
===============================================
+ Coverage           41%   44.19%   +3.18%     
===============================================
  Files               70      100      +30     
  Lines             9537    10847    +1310     
===============================================
+ Hits              3911     4794     +883     
- Misses            5061     5313     +252     
- Partials           565      740     +175
Flag Coverage Δ
#linux 47.87% <ø> (?)
#windows 41% <ø> (ø) ⬆️
Impacted Files Coverage Δ
mount/temp_unix.go 0% <0%> (ø)
sys/reaper_linux.go 0% <0%> (ø)
services/server/server_linux.go 0% <0%> (ø)
sys/env.go 100% <0%> (ø)
sys/stat_unix.go 0% <0%> (ø)
runtime/v2/shim/shim_unix.go 0% <0%> (ø)
sys/reaper.go 0% <0%> (ø)
sys/fds.go 0% <0%> (ø)
sys/proc.go 0% <0%> (ø)
sys/mount_linux.go 0% <0%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2383a5...342c953. Read the comment docs.

Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxpv mxpv merged commit a287c08 into containerd:release/1.2 Nov 10, 2019
@thaJeztah thaJeztah deleted the 1.2_backport_bump_golang_1.12.13 branch November 10, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants