Skip to content

Update to Golang 1.12.13#3806

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
thaJeztah:bump_golang_1.12.13
Nov 8, 2019
Merged

Update to Golang 1.12.13#3806
crosbymichael merged 1 commit intocontainerd:masterfrom
thaJeztah:bump_golang_1.12.13

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

go1.12.13 (released 2019/10/31) fixes an issue on macOS 10.15 Catalina
where the non-notarized installer and binaries were being rejected by
Gatekeeper. Only macOS users who hit this issue need to update.

go1.12.13 (released 2019/10/31) fixes an issue on macOS 10.15 Catalina
where the non-notarized installer and binaries were being rejected by
Gatekeeper. Only macOS users who hit this issue need to update.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Comment thread .travis.yml

go:
- "1.12.x"
- "1.12.13"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as #3620 (comment)

Changed this to be an explicit version as well; thought that if we'd have to update the AppVeyor config anyway, so might as well pin both travis and appveyor to use an explicit version

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Nov 8, 2019

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 8, 2019

Codecov Report

Merging #3806 into master will decrease coverage by 3.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3806      +/-   ##
==========================================
- Coverage   45.42%   41.98%   -3.45%     
==========================================
  Files         117      130      +13     
  Lines       11681    14577    +2896     
==========================================
+ Hits         5306     6120     +814     
- Misses       5462     7543    +2081     
- Partials      913      914       +1
Flag Coverage Δ
#linux 45.42% <ø> (ø) ⬆️
#windows 36.94% <ø> (?)
Impacted Files Coverage Δ
archive/tar_opts.go 58.82% <0%> (-12.61%) ⬇️
snapshots/native/native.go 42.42% <0%> (-10.27%) ⬇️
metadata/snapshot.go 47.84% <0%> (-8.61%) ⬇️
cio/io.go 46.47% <0%> (-8.53%) ⬇️
archive/tar.go 48.18% <0%> (-8.51%) ⬇️
metadata/containers.go 49.84% <0%> (-6.26%) ⬇️
content/local/writer.go 58.65% <0%> (-5.55%) ⬇️
content/local/store.go 49.52% <0%> (-5.29%) ⬇️
metadata/adaptors.go 49.53% <0%> (-5.11%) ⬇️
metadata/images.go 57.41% <0%> (-4.97%) ⬇️
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e12854...15669a1. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 40ac923 into containerd:master Nov 8, 2019
@thaJeztah thaJeztah deleted the bump_golang_1.12.13 branch November 8, 2019 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants