bump google.golang.org/grpc v1.23.1#3767
Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom Oct 22, 2019
Merged
Conversation
Member
Author
|
oh, looks like it removed those files as well LOL; let me mark this "WIP" until #3759 is merged, to not merge unrelated changes in this PR |
thaJeztah
changed the title
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3767 +/- ##
=======================================
Coverage 41.97% 41.97%
=======================================
Files 131 131
Lines 14536 14536
=======================================
Hits 6101 6101
Misses 7526 7526
Partials 909 909
Continue to review full report at Codecov.
|
full diff: grpc/grpc-go@v1.23.0...v1.23.1 - grpc/grpc-go#3018 server: set and advertise max frame size of 16KB - grpc/grpc-go#3017 grpclb: fix deadlock in grpclb connection cache - Before the fix, if the timer to remove a SubConn fires at the same time NewSubConn cancels the timer, it caused a mutex leak and deadlock. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
changed the title
Member
Author
|
rebased; should be ready for review now |
|
Build succeeded.
|
AkihiroSuda
approved these changes
Oct 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note: this will probably fail CI until #3759 is merged(merged)full diff: grpc/grpc-go@v1.23.0...v1.23.1
same time NewSubConn cancels the timer, it caused a mutex leak
and deadlock.