Move autocomplete files to contrib/#3766
Merged
estesp merged 1 commit intocontainerd:masterfrom Oct 22, 2019
Merged
Conversation
thaJeztah
reviewed
Oct 19, 2019
|
Build succeeded.
|
fuweid
reviewed
Oct 21, 2019
estesp
force-pushed
the
move-autocomplete
branch
from
d804518 to
168b293
Compare
Since recent versions of `vndr` are going to remove the autocomplete scripts from the urfave vendored content, we will just move them into `contrib/` and reference them in the documentation from that location. Signed-off-by: Phil Estes <[email protected]>
estesp
force-pushed
the
move-autocomplete
branch
from
168b293 to
3bf461a
Compare
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3766 +/- ##
==========================================
- Coverage 41.97% 37.08% -4.89%
==========================================
Files 131 89 -42
Lines 14536 12172 -2364
==========================================
- Hits 6101 4514 -1587
+ Misses 7526 7036 -490
+ Partials 909 622 -287
Continue to review full report at Codecov.
|
mrueg
added a commit
to mrueg/containerd
that referenced
this pull request
Oct 28, 2019
Since autocompletions moved to contrib/ in containerd#3766 Signed-off-by: Manuel Rüger <[email protected]>
tussennet
pushed a commit
to tussennet/containerd
that referenced
this pull request
Sep 11, 2020
Since autocompletions moved to contrib/ in containerd#3766 Signed-off-by: Manuel Rüger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since recent versions of
vndrare going to remove the autocompletescripts from the urfave vendored content, we will just move them into
contrib/and reference them in the documentation from that location.See #3759 for background
Signed-off-by: Phil Estes [email protected]