Skip to content

[release/1.3] snapshots/native: ignore xattr errors during CopyDir#3751

Merged
crosbymichael merged 1 commit intocontainerd:release/1.3from
AkihiroSuda:native-copydir-allow-xattr-errors-1.3
Oct 14, 2019
Merged

[release/1.3] snapshots/native: ignore xattr errors during CopyDir#3751
crosbymichael merged 1 commit intocontainerd:release/1.3from
AkihiroSuda:native-copydir-allow-xattr-errors-1.3

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

cherry-pick #3749

`secuity.*` xattrs cannot be copied in most cases

For moby/buildkit#1189

Signed-off-by: Akihiro Suda <[email protected]>
(cherry picked from commit d52cbc1)
Signed-off-by: Akihiro Suda <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Oct 14, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 14, 2019

Codecov Report

Merging #3751 into release/1.3 will decrease coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.3    #3751      +/-   ##
===============================================
- Coverage         45.6%   45.59%   -0.01%     
===============================================
  Files              116      116              
  Lines            11458    11463       +5     
===============================================
+ Hits              5225     5227       +2     
- Misses            5334     5336       +2     
- Partials           899      900       +1
Flag Coverage Δ
#linux 45.59% <33.33%> (-0.01%) ⬇️
Impacted Files Coverage Δ
snapshots/native/native.go 52.68% <33.33%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3866900...f6a32a7. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 7aaa8fc into containerd:release/1.3 Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants