Skip to content

snapshots/native: ignore xattr errors during CopyDir#3749

Merged
fuweid merged 1 commit intocontainerd:masterfrom
AkihiroSuda:native-copydir-allow-xattr-errors
Oct 14, 2019
Merged

snapshots/native: ignore xattr errors during CopyDir#3749
fuweid merged 1 commit intocontainerd:masterfrom
AkihiroSuda:native-copydir-allow-xattr-errors

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

secuity.* xattrs cannot be copied in most cases

For moby/buildkit#1189

Signed-off-by: Akihiro Suda [email protected]

`secuity.*` xattrs cannot be copied in most cases

For moby/buildkit#1189

Signed-off-by: Akihiro Suda <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Oct 12, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3749 into master will decrease coverage by 0.02%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3749      +/-   ##
==========================================
- Coverage   41.99%   41.97%   -0.03%     
==========================================
  Files         131      131              
  Lines       14528    14536       +8     
==========================================
  Hits         6101     6101              
- Misses       7520     7526       +6     
- Partials      907      909       +2
Flag Coverage Δ
#linux 45.39% <33.33%> (-0.02%) ⬇️
#windows 37.08% <0%> (-0.03%) ⬇️
Impacted Files Coverage Δ
snapshots/native/native.go 42.42% <22.22%> (-0.63%) ⬇️
snapshots/btrfs/btrfs.go 57.39% <0%> (-0.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57cfc90...d52cbc1. Read the comment docs.

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants