Fix flaky btrfs test#3720
Merged
mxpv merged 1 commit intocontainerd:masterfrom Oct 7, 2019
Merged
Conversation
Add logging and move the creation of the snapshotter inside the attempt loop to catch cases where the mountinfo may not be updated yet. When all attempts are reached there is no reason to create the snapshotter as the unmount has already occurred. Signed-off-by: Derek McGowan <[email protected]>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3720 +/- ##
======================================
Coverage 42.1% 42.1%
======================================
Files 129 129
Lines 14307 14307
======================================
Hits 6024 6024
Misses 7383 7383
Partials 900 900
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
Oct 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The btrfs tests are still flaky, this change may not fix the flaky test but will provide more information. Previously the error message was not helpful since it was the result of a creation attempt after unmount.
Add logging and move the creation of the snapshotter inside
the attempt loop to catch cases where the mountinfo may
not be updated yet. When all attempts are reached there
is no reason to create the snapshotter as the unmount has
already occurred.
Signed-off-by: Derek McGowan [email protected]