Skip to content

Fix all media types in Accept header to match RFC#3696

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
dmcgowan:fix-all-media-types
Sep 26, 2019
Merged

Fix all media types in Accept header to match RFC#3696
dmcgowan merged 1 commit intocontainerd:masterfrom
dmcgowan:fix-all-media-types

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan commented Sep 26, 2019

Fixes the media type to align with Accept HTTP header RFC which specifies glob syntax /

See https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html

Related to #3291

Fixes the media type to align with Accept HTTP header
RFC which specifies glob syntax */*

See https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html

Signed-off-by: Derek McGowan <[email protected]>
Copy link
Copy Markdown
Member

@stevvooe stevvooe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 26, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 26, 2019

Codecov Report

Merging #3696 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3696   +/-   ##
======================================
  Coverage    42.1%   42.1%           
======================================
  Files         129     129           
  Lines       14307   14307           
======================================
  Hits         6024    6024           
  Misses       7383    7383           
  Partials      900     900
Flag Coverage Δ
#linux 45.61% <66.66%> (ø) ⬆️
#windows 37.05% <66.66%> (ø) ⬆️
Impacted Files Coverage Δ
remotes/docker/pusher.go 0% <0%> (ø) ⬆️
remotes/docker/resolver.go 53.97% <100%> (ø) ⬆️
remotes/docker/fetcher.go 50% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6624f62...394db03. Read the comment docs.

@dmcgowan dmcgowan added this to the 1.3 milestone Sep 26, 2019
@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@dmcgowan dmcgowan merged commit a668365 into containerd:master Sep 26, 2019
@dmcgowan dmcgowan deleted the fix-all-media-types branch September 26, 2019 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants