Skip to content

Get CRI dependency versions from containerd vendor.conf.#3692

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
Random-Liu:cri-dependency-version
Sep 26, 2019
Merged

Get CRI dependency versions from containerd vendor.conf.#3692
crosbymichael merged 1 commit intocontainerd:masterfrom
Random-Liu:cri-dependency-version

Conversation

@Random-Liu
Copy link
Copy Markdown
Member

@Random-Liu Random-Liu commented Sep 26, 2019

Get CRI dependency versions from the containerd vendor.conf.

The vendor.conf in cri might be out of date, the containerd vendor.conf should be the source of truth for actual release.

Signed-off-by: Lantao Liu [email protected]

@Random-Liu Random-Liu added this to the 1.3 milestone Sep 26, 2019
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 26, 2019

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 26, 2019

Codecov Report

Merging #3692 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3692   +/-   ##
======================================
  Coverage    42.1%   42.1%           
======================================
  Files         129     129           
  Lines       14307   14307           
======================================
  Hits         6024    6024           
  Misses       7383    7383           
  Partials      900     900
Flag Coverage Δ
#linux 45.61% <ø> (ø) ⬆️
#windows 37.05% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 277ab9e...1b1b862. Read the comment docs.

@crosbymichael crosbymichael merged commit 6624f62 into containerd:master Sep 26, 2019
@Random-Liu Random-Liu deleted the cri-dependency-version branch September 26, 2019 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants