Skip to content

gen-manpages: Create man directory if it does not exist#3673

Merged
fuweid merged 1 commit intocontainerd:masterfrom
seemethere:mkdir_man
Sep 24, 2019
Merged

gen-manpages: Create man directory if it does not exist#3673
fuweid merged 1 commit intocontainerd:masterfrom
seemethere:mkdir_man

Conversation

@seemethere
Copy link
Copy Markdown
Contributor

make genman does not work if the man directory does not exist first

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 23, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 23, 2019

Codecov Report

Merging #3673 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3673   +/-   ##
======================================
  Coverage      42%     42%           
======================================
  Files         129     129           
  Lines       14275   14275           
======================================
  Hits         5996    5996           
  Misses       7379    7379           
  Partials      900     900
Flag Coverage Δ
#linux 45.51% <ø> (ø) ⬆️
#windows 36.91% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af133f...2a636f8. Read the comment docs.

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 94c4979 into containerd:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants