Check for more kill error types#3672
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Sep 23, 2019
Merged
Conversation
Signed-off-by: Michael Crosby <[email protected]>
|
Build succeeded.
|
mxpv
reviewed
Sep 23, 2019
| } | ||
| if strings.Contains(err.Error(), "os: process already finished") || | ||
| strings.Contains(err.Error(), "container not running") || | ||
| strings.Contains(strings.ToLower(err.Error()), "no such process") || |
Member
There was a problem hiding this comment.
Is this different from unix.ESRCH {3, "ESRCH", "no such process"} check 1 line below? (link)
Member
Author
There was a problem hiding this comment.
just a string comp whenever the error is returned via stderr from a runtime process
mxpv
approved these changes
Sep 23, 2019
estesp
approved these changes
Sep 23, 2019
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM
re-running flake failure on one of the 4 travis CI jobs
Codecov Report
@@ Coverage Diff @@
## master #3672 +/- ##
======================================
Coverage 42% 42%
======================================
Files 129 129
Lines 14275 14275
======================================
Hits 5996 5996
Misses 7379 7379
Partials 900 900
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
crunsupport.Signed-off-by: Michael Crosby [email protected]