Add metrics type alias#3666
Merged
fuweid merged 1 commit intocontainerd:masterfrom Sep 20, 2019
Merged
Conversation
This will help to decouple the import in CRI from the cgroups package directly by importing the type alias in containerd repo. Signed-off-by: Michael Crosby <[email protected]>
jterry75
approved these changes
Sep 19, 2019
Contributor
jterry75
left a comment
jterry75
left a comment
There was a problem hiding this comment.
Oh great thanks for doing this side! LGTM
Member
Author
|
@jterry75 i'll have to update CRI with this change then I can bump the |
|
Build succeeded.
|
Contributor
Yea I'm not sure either. But the theory seems good :) |
Member
Author
|
Travis passed, it's just not updated on github |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help to decouple the import in CRI from the cgroups package
directly by importing the type alias in containerd repo.
Signed-off-by: Michael Crosby [email protected]