Skip to content

Move golangci-lint deadline to config file#3665

Merged
fuweid merged 1 commit intocontainerd:masterfrom
estesp:golangcideadline
Sep 19, 2019
Merged

Move golangci-lint deadline to config file#3665
fuweid merged 1 commit intocontainerd:masterfrom
estesp:golangcideadline

Conversation

@estesp
Copy link
Copy Markdown
Member

@estesp estesp commented Sep 19, 2019

As mentioned here might as well put it in our existing config file.

Signed-off-by: Phil Estes [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 19, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 19, 2019

Codecov Report

Merging #3665 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3665   +/-   ##
======================================
  Coverage      42%     42%           
======================================
  Files         129     129           
  Lines       14275   14275           
======================================
  Hits         5996    5996           
  Misses       7379    7379           
  Partials      900     900
Flag Coverage Δ
#linux 45.51% <ø> (ø) ⬆️
#windows 36.91% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fafc8a...57b51b9. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit d4802a6 into containerd:master Sep 19, 2019
@estesp estesp deleted the golangcideadline branch September 19, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants