Get media type key from context#3661
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Sep 18, 2019
Merged
Conversation
|
Build succeeded.
|
cpuguy83
force-pushed
the
custom_keys_for_fetch_hander
branch
from
8b25d90 to
a1d37f1
Compare
|
Build succeeded.
|
Adds a method for setting a custom media type key prefix used by the fetch handler. This allows both overwriting a built-in prefix (for reasons?) as well as supplying a custom media type. I added this because I was getting an error on `FetchHandler` when pulling docker plugin images which have their own media type. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
custom_keys_for_fetch_hander
branch
from
a1d37f1 to
bca374a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3661 +/- ##
==========================================
- Coverage 42.37% 36.83% -5.54%
==========================================
Files 127 87 -40
Lines 14075 11943 -2132
==========================================
- Hits 5964 4399 -1565
+ Misses 7211 6930 -281
+ Partials 900 614 -286
Continue to review full report at Codecov.
|
|
Build succeeded.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a method for setting a custom media type key prefix used by the
fetch handler.
This allows both overwriting a built-in prefix (for reasons?) as well as
supplying a custom media type.
I added this because I was getting an error on
FetchHandlerwhenpulling docker plugin images which have their own media type.