Skip to content

Makefile: increase deadline to 2m for golangci-lint#3660

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
fuweid:me-golint
Sep 18, 2019
Merged

Makefile: increase deadline to 2m for golangci-lint#3660
crosbymichael merged 1 commit intocontainerd:masterfrom
fuweid:me-golint

Conversation

@fuweid
Copy link
Copy Markdown
Member

@fuweid fuweid commented Sep 18, 2019

Signed-off-by: Wei Fu [email protected]

@fuweid
Copy link
Copy Markdown
Member Author

fuweid commented Sep 18, 2019 •
edited
Loading

multiple prs has the lint deadline issue

ref:

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 18, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 18, 2019 •
edited
Loading

Codecov Report

Merging #3660 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3660   +/-   ##
=======================================
  Coverage   42.39%   42.39%           
=======================================
  Files         127      127           
  Lines       14048    14048           
=======================================
  Hits         5955     5955           
  Misses       7193     7193           
  Partials      900      900
Flag Coverage Δ
#linux 45.9% <ø> (ø) ⬆️
#windows 37.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87bff67...83a7285. Read the comment docs.

@fuweid
Copy link
Copy Markdown
Member Author

fuweid commented Sep 18, 2019 

The command "go build -i ." exited with 0.
56.72s$ make check
+ proto-fmt
+ check
GOGC=75 golangci-lint run --deadline 2m

56.72s lucky one

estesp
estesp approved these changes Sep 18, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp added this to the 1.3 milestone Sep 18, 2019
@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Sep 18, 2019

LGTM

@crosbymichael crosbymichael merged commit e4dc2f6 into containerd:master Sep 18, 2019
@ehotinger
Copy link
Copy Markdown
Contributor

ehotinger commented Sep 18, 2019

should put this in the .golangci.yml:

run:
  deadline: 2m

@estesp estesp mentioned this pull request Sep 19, 2019
Merged
@fuweid fuweid deleted the me-golint branch September 19, 2019 13:51
@estesp estesp mentioned this pull request Mar 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

5 participants

@fuweid @codecov-io @crosbymichael @ehotinger @estesp