Try set GOGC for golint#3657
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Sep 17, 2019
Merged
Conversation
|
Build succeeded.
|
crosbymichael
force-pushed
the
golint
branch
from
c256ad7 to
160e8b6
Compare
|
Build succeeded.
|
crosbymichael
force-pushed
the
golint
branch
2 times, most recently
from
7ffb10b to
603884d
Compare
|
Build succeeded.
|
crosbymichael
force-pushed
the
golint
branch
from
603884d to
d934d7c
Compare
|
Build succeeded.
|
crosbymichael
force-pushed
the
golint
branch
2 times, most recently
from
6547760 to
26ea074
Compare
|
Build succeeded.
|
crosbymichael
force-pushed
the
golint
branch
from
26ea074 to
bcda029
Compare
|
Build succeeded.
|
crosbymichael
force-pushed
the
golint
branch
from
bcda029 to
fd8ebb2
Compare
|
Build succeeded.
|
Signed-off-by: Michael Crosby <[email protected]>
crosbymichael
force-pushed
the
golint
branch
from
fd8ebb2 to
3bc9975
Compare
|
Build succeeded.
|
estesp
approved these changes
Sep 17, 2019
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM
Looks like GOGC=75 + v1.18 of golangci-lint is a working combination for both Travis and Appveyor
Codecov Report
@@ Coverage Diff @@
## master #3657 +/- ##
=======================================
Coverage 42.39% 42.39%
=======================================
Files 127 127
Lines 14048 14048
=======================================
Hits 5955 5955
Misses 7193 7193
Partials 900 900
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Crosby [email protected]