implement ctr --connect-timeout#3653
Merged
estesp merged 1 commit intocontainerd:masterfrom Sep 16, 2019
Merged
Conversation
|
Build succeeded.
|
Member
|
Hi, @lalyos thanks for contribution. could you mind to repush it to trigger the CI again? since we have flaky case here. Thanks |
Signed-off-by: Lajos Papp <[email protected]>
lalyos
force-pushed
the
fix-connect-timeout
branch
from
e1e14ec to
19ecd49
Compare
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3653 +/- ##
=======================================
Coverage 42.39% 42.39%
=======================================
Files 127 127
Lines 14048 14048
=======================================
Hits 5955 5955
Misses 7193 7193
Partials 900 900
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
connect-timeoutglobal flag was already defined, but not used.