Fix missing vendor packages#3650
Conversation
The switch to urfave/cli had a use of a /v2 API, which go modules handles correctly but vndr ignores. Downgrade urfave/cli for now until the switch to go modules. Add missing dependencies, which vndr now sees. Note that CI was not catching this issue, it seems that some part of the build process was pulling in dependencies even if they weren't in vendor, causing the build to work. However the vendor check was not seeing it. The ARM build didn't pull in other dependencies into the gopath, causing those builds to break. Signed-off-by: Derek McGowan <[email protected]>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3650 +/- ##
=======================================
Coverage 42.39% 42.39%
=======================================
Files 127 127
Lines 14048 14048
=======================================
Hits 5955 5955
Misses 7193 7193
Partials 900 900
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3650 +/- ##
=======================================
Coverage 42.39% 42.39%
=======================================
Files 127 127
Lines 14048 14048
=======================================
Hits 5955 5955
Misses 7193 7193
Partials 900 900
Continue to review full report at Codecov.
|
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM
I checked out this PR's vendor changes with make genman and it is correctly producing manpages, so looks like this is OK for now (to go back to urfave/cli v1.22)
|
LGTM |
5 participants
The switch to urfave/cli had a use of a /v2 API, which
go modules handles correctly but vndr ignores. Downgrade
urfave/cli for now until the switch to go modules. Add
missing dependencies, which vndr now sees.
Note that CI was not catching this issue, it seems that
some part of the build process was pulling in dependencies
even if they weren't in vendor, causing the build to work.
However the vendor check was not seeing it. The ARM build
didn't pull in other dependencies into the gopath, causing
those builds to break.
closes #3645
@crosbymichael was there something in that package required after v1.22.0?