Skip to content

Move manpage gen to separate binary#3648

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
crosbymichael:man-bin
Sep 12, 2019
Merged

Move manpage gen to separate binary#3648
dmcgowan merged 1 commit intocontainerd:masterfrom
crosbymichael:man-bin

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

This moves the man page generation to a separate binary

Signed-off-by: Michael Crosby [email protected]

This moves the man page generation to a separate binary

Signed-off-by: Michael Crosby <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 12, 2019

Build succeeded.

Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3648 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3648   +/-   ##
=======================================
  Coverage   42.39%   42.39%           
=======================================
  Files         127      127           
  Lines       14048    14048           
=======================================
  Hits         5955     5955           
  Misses       7193     7193           
  Partials      900      900
Flag Coverage Δ
#linux 45.9% <ø> (ø) ⬆️
#windows 37.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c77ec3...5a656ca. Read the comment docs.

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 9741f03 into containerd:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants