Update gcs cri release.#3638
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Sep 11, 2019
Merged
Conversation
Random-Liu
force-pushed
the
upload-gcs-cri-release
branch
2 times, most recently
from
4fab810 to
b29be46
Compare
|
Build succeeded.
|
Random-Liu
force-pushed
the
upload-gcs-cri-release
branch
from
b29be46 to
36c9c99
Compare
Random-Liu
force-pushed
the
upload-gcs-cri-release
branch
from
36c9c99 to
a377bc4
Compare
|
Build succeeded.
|
Member
|
This is having the same issue as my other PR, not sure if some change to the .travis.yml file causes Travis to reject the job. |
Random-Liu
force-pushed
the
upload-gcs-cri-release
branch
from
a377bc4 to
26ce579
Compare
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3638 +/- ##
==========================================
- Coverage 42.39% 37.27% -5.12%
==========================================
Files 127 85 -42
Lines 14048 11721 -2327
==========================================
- Hits 5955 4369 -1586
+ Misses 7193 6738 -455
+ Partials 900 614 -286
Continue to review full report at Codecov.
|
Member
|
Needs a rebase here |
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
upload-gcs-cri-release
branch
from
26ce579 to
d1a1282
Compare
Member
Author
|
Rebased |
|
Build succeeded.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #3627
Install gcloud and upload CRI release to gcs ourselves. We don't use travis deploy because there is an issue in the gcs support there travis-ci/dpl#792.
Signed-off-by: Lantao Liu [email protected]