Skip to content

[CI] fix darwin build for cri release#3636

Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom
dmcgowan:fix-cri-darwin-release
Sep 11, 2019
Merged

[CI] fix darwin build for cri release#3636
AkihiroSuda merged 1 commit intocontainerd:masterfrom
dmcgowan:fix-cri-darwin-release

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

Fix Darwin build and split release target for cri release

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 10, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 10, 2019

Codecov Report

Merging #3636 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3636   +/-   ##
=======================================
  Coverage   42.39%   42.39%           
=======================================
  Files         127      127           
  Lines       14048    14048           
=======================================
  Hits         5955     5955           
  Misses       7193     7193           
  Partials      900      900
Flag Coverage Δ
#linux 45.9% <ø> (ø) ⬆️
#windows 37.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5403e55...3db5a5a. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@dmcgowan dmcgowan force-pushed the fix-cri-darwin-release branch from 871cd05 to 12400ea Compare September 10, 2019 23:37
Split release target for cri

Signed-off-by: Derek McGowan <[email protected]>
@dmcgowan dmcgowan force-pushed the fix-cri-darwin-release branch from 12400ea to 3db5a5a Compare September 10, 2019 23:38
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 10, 2019

Build succeeded.

@AkihiroSuda AkihiroSuda merged commit 9dccbaa into containerd:master Sep 11, 2019
@dmcgowan dmcgowan deleted the fix-cri-darwin-release branch March 23, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants