Skip to content

Update cri test to fix image reference test.#3635

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
Random-Liu:update-cri-tools
Sep 10, 2019
Merged

Update cri test to fix image reference test.#3635
dmcgowan merged 1 commit intocontainerd:masterfrom
Random-Liu:update-cri-tools

Conversation

@Random-Liu
Copy link
Copy Markdown
Member

@Random-Liu Random-Liu commented Sep 10, 2019 •
edited
Loading

Update cri validation test to fix the image reference test:

• Failure [1.718 seconds]
[k8s.io] Image Manager
/home/travis/gopath/src/github.com/kubernetes-sigs/cri-tools/pkg/framework/framework.go:72
  public image without tag should be pulled and removed [Conformance] [It]
  /home/travis/gopath/src/github.com/kubernetes-sigs/cri-tools/pkg/validate/image.go:47
  failed to pull image: rpc error: code = NotFound desc = failed to pull and unpack image "gcr.io/cri-tools/test-image-latest:latest": unpack: failed to prepare extraction snapshot "extract-151995760-DQ8D sha256:749539d5cc3b63b2fd60be0340a8e7ca88fd6fe0c639a605d46d3513778ac7f7": parent snapshot sha256:0d315111b4847e8cd50514ca19657d1e8d827f4e128d172ce8b2f76a04f3faea does not exist: not found
  Unexpected error:
      <*status.statusError | 0xc00024cfa0>: {
          Code: 5,
          Message: "failed to pull and unpack image \"gcr.io/cri-tools/test-image-latest:latest\": unpack: failed to prepare extraction snapshot \"extract-151995760-DQ8D sha256:749539d5cc3b63b2fd60be0340a8e7ca88fd6fe0c639a605d46d3513778ac7f7\": parent snapshot sha256:0d315111b4847e8cd50514ca19657d1e8d827f4e128d172ce8b2f76a04f3faea does not exist: not found",
          Details: nil,
          XXX_NoUnkeyedLiteral: {},
          XXX_unrecognized: nil,
          XXX_sizecache: 0,
      }
      rpc error: code = NotFound desc = failed to pull and unpack image "gcr.io/cri-tools/test-image-latest:latest": unpack: failed to prepare extraction snapshot "extract-151995760-DQ8D sha256:749539d5cc3b63b2fd60be0340a8e7ca88fd6fe0c639a605d46d3513778ac7f7": parent snapshot sha256:0d315111b4847e8cd50514ca19657d1e8d827f4e128d172ce8b2f76a04f3faea does not exist: not found
  occurred
  /home/travis/gopath/src/github.com/kubernetes-sigs/cri-tools/pkg/framework/util.go:328

The fix: kubernetes-sigs/cri-tools#503

Signed-off-by: Lantao Liu [email protected]

@Random-Liu Random-Liu added this to the 1.3 milestone Sep 10, 2019
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 10, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 10, 2019 •
edited
Loading

Codecov Report

Merging #3635 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3635   +/-   ##
=======================================
  Coverage   42.39%   42.39%           
=======================================
  Files         127      127           
  Lines       14048    14048           
=======================================
  Hits         5955     5955           
  Misses       7193     7193           
  Partials      900      900
Flag Coverage Δ
#linux 45.9% <ø> (ø) ⬆️
#windows 37.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce8d632...1b4cec9. Read the comment docs.

@Random-Liu
Copy link
Copy Markdown
Member Author

Random-Liu commented Sep 10, 2019 •
edited
Loading

This PR also switches to use master branch of travis deploy to work around travis-ci/dpl#792.

The final deploy step doesn't succeed, and we can't get any useful error message because of travis-ci/dpl#792.

If this still doesn't work, I'll probably install gcloud and copy the tarballs to gcs bucket in the script instead.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 10, 2019

Build succeeded.

dmcgowan
dmcgowan approved these changes Sep 10, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 5403e55 into containerd:master Sep 10, 2019
@Random-Liu Random-Liu deleted the update-cri-tools branch September 10, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

Assignees

@dmcgowan dmcgowan

Labels

None yet

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

3 participants

@Random-Liu @codecov-io @dmcgowan