Skip to content

Add --env-file to ctr#3628

Merged
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:ctr-env
Sep 6, 2019
Merged

Add --env-file to ctr#3628
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:ctr-env

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

@crosbymichael crosbymichael commented Sep 6, 2019

Closes #3517

Signed-off-by: Michael Crosby [email protected]

@crosbymichael
Add --env-file to ctr
fa11147 
Closes containerd#3517

Signed-off-by: Michael Crosby <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 6, 2019

Build succeeded.

dmcgowan
dmcgowan approved these changes Sep 6, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan added this to the 1.3 milestone Sep 6, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 6, 2019

Codecov Report

Merging #3628 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3628      +/-   ##
==========================================
- Coverage   42.43%   42.39%   -0.05%     
==========================================
  Files         127      127              
  Lines       14032    14048      +16     
==========================================
  Hits         5955     5955              
- Misses       7177     7193      +16     
  Partials      900      900
Flag Coverage Δ
#linux 45.9% <0%> (-0.06%) ⬇️
#windows 37.27% <0%> (-0.06%) ⬇️
Impacted Files Coverage Δ
oci/spec_opts.go 30.61% <0%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ddfc6d...fa11147. Read the comment docs.

2 similar comments
@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 6, 2019

Codecov Report

Merging #3628 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3628      +/-   ##
==========================================
- Coverage   42.43%   42.39%   -0.05%     
==========================================
  Files         127      127              
  Lines       14032    14048      +16     
==========================================
  Hits         5955     5955              
- Misses       7177     7193      +16     
  Partials      900      900
Flag Coverage Δ
#linux 45.9% <0%> (-0.06%) ⬇️
#windows 37.27% <0%> (-0.06%) ⬇️
Impacted Files Coverage Δ
oci/spec_opts.go 30.61% <0%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ddfc6d...fa11147. Read the comment docs.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 6, 2019

Codecov Report

Merging #3628 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3628      +/-   ##
==========================================
- Coverage   42.43%   42.39%   -0.05%     
==========================================
  Files         127      127              
  Lines       14032    14048      +16     
==========================================
  Hits         5955     5955              
- Misses       7177     7193      +16     
  Partials      900      900
Flag Coverage Δ
#linux 45.9% <0%> (-0.06%) ⬇️
#windows 37.27% <0%> (-0.06%) ⬇️
Impacted Files Coverage Δ
oci/spec_opts.go 30.61% <0%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ddfc6d...fa11147. Read the comment docs.

estesp
estesp approved these changes Sep 6, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 61b127f into containerd:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

adding --env-file flag to ctr

4 participants

@crosbymichael @codecov-io @dmcgowan @estesp