platforms: update known OS and arch values#3624
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Sep 5, 2019
Merged
Conversation
Update the lists in isKnownOS and isKnownOS according to goosList and goarchList taken from Go 1.13, see https://github.com/golang/go/blob/release-branch.go1.13/src/go/build/syslist.go Signed-off-by: Tobias Klauser <[email protected]>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3624 +/- ##
==========================================
- Coverage 45.96% 42.43% -3.53%
==========================================
Files 114 127 +13
Lines 11242 14032 +2790
==========================================
+ Hits 5167 5955 +788
- Misses 5176 7177 +2001
- Partials 899 900 +1
Continue to review full report at Codecov.
|
Member
|
do we need to wait for upgrading golang pr #3620 ? |
Member
|
LGTM @fuweid these functions are just used to determine whether a single valued input is an OS or architecture. Generally single value inputs are discouraged and any of these values would already be supported when explicitly give as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the lists in isKnownOS and isKnownOS according to goosList and
goarchList taken from Go 1.13, see
https://github.com/golang/go/blob/release-branch.go1.13/src/go/build/syslist.go
Signed-off-by: Tobias Klauser [email protected]