config_test: sort result before check#3623
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Sep 5, 2019
Merged
Conversation
|
Build succeeded.
|
Contributor
|
/ LGTM |
config imports is in random order after LoadConfig call so that the testing check should be done after sort.Strings(out.Imports). Signed-off-by: Wei Fu <[email protected]>
fuweid
force-pushed
the
me-sort-before-check
branch
from
ea1b57a to
3d1fdac
Compare
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3623 +/- ##
==========================================
- Coverage 45.96% 42.43% -3.53%
==========================================
Files 114 127 +13
Lines 11242 14032 +2790
==========================================
+ Hits 5167 5955 +788
- Misses 5176 7177 +2001
- Partials 899 900 +1
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config imports is in random order after LoadConfig call so that the
testing check should be done after sort.Strings(out.Imports).
Signed-off-by: Wei Fu [email protected]