Probably want to wait until after the 1.3.0 release, but opening to see if everything works smoothly on the new version (thought I already opened a PR to test that, but apparently forgot 😥)

(FWIW, on the Moby repository we ran into some weird stuff (as usual) when testing against 1.13 moby/moby#39549)

Build succeeded.

• containerd-build-arm64 : SUCCESS in 7m 53s (non-voting)

Ah, interesting;

$ if [ "$TRAVIS_GOOS" = "linux" ]; then sudo PATH=$PATH GOPATH=$GOPATH make integration ; fi
+ integration
flag provided but not defined: -test.parallel
Usage of /tmp/go-build542105590/b001/containerd.test:
  -address string
    	The address to the containerd socket for use in the tests (default "/run/containerd-test/containerd.sock")
  -no-criu
    	Do not run the checkpoint tests
  -no-daemon
    	Do not start a dedicated daemon for the tests
  -test.root
    	enable tests that require root
exit status 2
FAIL	github.com/containerd/containerd	0.032s
Makefile:171: recipe for target 'integration' failed
make: *** [integration] Error 1
The command "if [ "$TRAVIS_GOOS" = "linux" ]; then sudo PATH=$PATH GOPATH=$GOPATH make integration ; fi" exited with 2.

Build succeeded.

• containerd-build-arm64 : SUCCESS in 6m 41s (non-voting)

Codecov Report

Merging #3620 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3620      +/-   ##
==========================================
- Coverage   41.99%   41.98%   -0.02%     
==========================================
  Files         130      130              
  Lines       14577    14577              
==========================================
- Hits         6122     6120       -2     
- Misses       7542     7543       +1     
- Partials      913      914       +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40ac923...608791b. Read the comment docs.

Build succeeded.

• containerd-build-arm64 : SUCCESS in 6m 08s (non-voting)

Looks like I found it; looks like it fails if -race is enabled and flags.Parse() is called;

mkdir 113_regression && cd 113_regression

cat > repro_test.go <<EOF
package main

import "flag"
import "testing"

func init() { flag.Parse() }

func TestHello(t *testing.T) {}
EOF

On Go 1.12

go get golang.org/dl/go1.12.9 && go1.12.9 download

go1.12.9 test -race -test.parallel 8

# PASS
# ok  	_/go/113_regression	1.009s

On Go 1.13, running the test fails

go get golang.org/dl/go1.13 && go1.13 download

go1.13 test -race -test.parallel 8

# flag provided but not defined: -test.parallel
# Usage of /tmp/go-build008991056/b001/113_regression.test:
# exit status 2
# FAIL	_/go/113_regression	0.008s

The problem looks related to calling flag.Parse(). Trying an example on Go 1.13 on a test without flag.Parse()

cat > repro_test.go <<EOF
package main

import "testing"

func TestHello(t *testing.T) {}
EOF


go1.13 test -race -test.parallel 8

# PASS
# ok  	_/go/113_regression	1.009s

Reported an issue golang/go#34073

Apparently this was a known change in behavior; see golang/go#31859

@kevpar - FYI

Love it! Lets see how it does

Build succeeded.

• containerd-build-arm64 : SUCCESS in 5m 49s (non-voting)

Can you rebase this one now that 1.3 is out?

Rebased, and updated to Go 1.13.1. I dropped the second commit, as it was merged in #3744

Build succeeded.

• containerd-build-arm64 : SUCCESS in 10m 21s (non-voting)

After this has been merged we could update to Golang 1.13.3 for CVE-2019-17596.

Let me open a quick PR to update to Go 1.12.12 first, in case we want to backport that to existing release branches where we may not want to bump to Go 1.13 immediately.

Opened #3760

needs rebase

rebased, and updated to go 1.13.4

Build succeeded.

• containerd-build-arm64 : SUCCESS in 5m 49s (non-voting)

Also opened #3806 to bump master to Go 1.12.13; we may want to merge that one first if we want that to be cherry-picked into existing release branches

Build succeeded.

• containerd-build-arm64 : SUCCESS in 6m 09s (non-voting)

Arf. Looks like it's failing on some go mod issue;

go: github.com/golangci/[email protected]: invalid version: unknown revision 3540c026601b

Probably need to either disable go mod, or work outside of go path

Build succeeded.

• containerd-build-arm64 : SUCCESS in 7m 01s (non-voting)

i vote disable gomod

LGTM