Support foreign and encrypted layers in the unpacker.#3616
Support foreign and encrypted layers in the unpacker.#3616estesp merged 1 commit intocontainerd:masterfrom
Conversation
Signed-off-by: Lantao Liu <[email protected]>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3616 +/- ##
=======================================
Coverage 42.38% 42.38%
=======================================
Files 126 126
Lines 13901 13901
=======================================
Hits 5892 5892
Misses 7123 7123
Partials 886 886
Continue to review full report at Codecov.
|
|
We can merge this for now to fix the issue. having a function to check is probably a good idea. We might also want to do a prefix match before the "+" to support stuff like "zstd" without having to explicitly support it. The new stream processors can already handle it but I think currently we will end up filtering it with this sort of string matching. |
|
@dmcgowan SGTM. :) |
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM
Going to open a separate PR to update the encrypted layer media types to the most recent proposal in OCI to hopefully future-proof this set of strings for where the discussion is today across OCI and Kubernetes communities.
4 participants
Fix unpacker for foreign layers and encrypted layers.
Not sure whether we should add a helper to check whether a media type is a layer.
Signed-off-by: Lantao Liu [email protected]