Skip to content

travis: fix Xenial tests not being run on master#3614

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
thaJeztah:travis_bionic_take2
Sep 4, 2019
Merged

travis: fix Xenial tests not being run on master#3614
dmcgowan merged 1 commit intocontainerd:masterfrom
thaJeztah:travis_bionic_take2

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

Attempt number two (after #3606)

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 3, 2019

Build succeeded.

@thaJeztah
Copy link
Copy Markdown
Member Author

Ok; this looks to work so far; just filtering on pull_request events looks to exclude Xenial on PR's;

When opening the PR:

Screenshot 2019-09-04 at 01 38 08

After a rebase/force-push (which was what I thought the push event filter was needed for);

Screenshot 2019-09-04 at 01 38 50

@thaJeztah
Copy link
Copy Markdown
Member Author

@estesp PTAL; again, no idea if this works on master, but just filtering on pull_request so far looks hopeful.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 3, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3614 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3614   +/-   ##
=======================================
  Coverage   42.38%   42.38%           
=======================================
  Files         126      126           
  Lines       13901    13901           
=======================================
  Hits         5892     5892           
  Misses       7123     7123           
  Partials      886      886
Flag Coverage Δ
#linux 45.91% <ø> (ø) ⬆️
#windows 37.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48fb479...cd79e0e. Read the comment docs.

1 similar comment
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3614 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3614   +/-   ##
=======================================
  Coverage   42.38%   42.38%           
=======================================
  Files         126      126           
  Lines       13901    13901           
=======================================
  Hits         5892     5892           
  Misses       7123     7123           
  Partials      886      886
Flag Coverage Δ
#linux 45.91% <ø> (ø) ⬆️
#windows 37.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48fb479...cd79e0e. Read the comment docs.

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Sep 4, 2019

Not a big fan of making these CI changes when we are about to start our release cycle. Let's merge and see if it works.

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Sep 4, 2019

LGTM

@dmcgowan dmcgowan merged commit c7c7955 into containerd:master Sep 4, 2019
@thaJeztah thaJeztah deleted the travis_bionic_take2 branch September 4, 2019 00:55
@estesp
Copy link
Copy Markdown
Member

estesp commented Sep 4, 2019

it worked: https://travis-ci.org/containerd/containerd/builds/580494864; thanks @thaJeztah

@thaJeztah
Copy link
Copy Markdown
Member Author

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants