Fix potential panic for task in unknown state.#3611
Merged
estesp merged 1 commit intocontainerd:masterfrom Sep 3, 2019
Merged
Conversation
Signed-off-by: Lantao Liu <[email protected]>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3611 +/- ##
==========================================
+ Coverage 42.38% 42.38% +<.01%
==========================================
Files 126 126
Lines 13900 13901 +1
==========================================
+ Hits 5891 5892 +1
Misses 7123 7123
Partials 886 886
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added unknown state support for task in 101d4b7. And task in unknown state will have empty fifos path.
However, we continue attach IO for task in unknown state https://github.com/containerd/containerd/blob/master/container.go#L386, which will potentially trigger a panic, because
copyIOtries to access nilstdout.This PR:
Signed-off-by: Lantao Liu [email protected]