Update cri to 0165d516161e25e52b4ab52a404a00823f8f0ef6#3607
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Sep 4, 2019
awesomenix:updatecri
Merged
Update cri to 0165d516161e25e52b4ab52a404a00823f8f0ef6#3607dmcgowan merged 1 commit intocontainerd:masterfrom awesomenix:updatecri
dmcgowan merged 1 commit intocontainerd:masterfrom
awesomenix:updatecri
Conversation
Contributor
Author
|
/assign @Random-Liu |
Member
|
This commit isn't signed so CI is going to fail on the DCO check--easy fix |
Signed-off-by: Nishchay Kumar <[email protected]>
Contributor
Author
|
Thanks @estesp, thought Fixed release 1.2 branch as well |
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3607 +/- ##
==========================================
+ Coverage 42.39% 42.64% +0.25%
==========================================
Files 126 126
Lines 13891 13989 +98
==========================================
+ Hits 5889 5966 +77
- Misses 7116 7118 +2
- Partials 886 905 +19
Continue to review full report at Codecov.
|
Member
|
Pretty sure this bug fix should be in 1.3 // cc: @dmcgowan |
Member
|
LGTM The original PR was here containerd/cri#1253 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.