Skip to content

[release/1.2] cherry-pick: Use default UNIX env when image has no environment#3601

Merged
fuweid merged 1 commit intocontainerd:release/1.2from
estesp:cp-3599
Aug 30, 2019
Merged

[release/1.2] cherry-pick: Use default UNIX env when image has no environment#3601
fuweid merged 1 commit intocontainerd:release/1.2from
estesp:cp-3599

Conversation

@estesp
Copy link
Copy Markdown
Member

@estesp estesp commented Aug 29, 2019

Cherry-pick bc692cc from master PR #3599

Signed-off-by: Phil Estes [email protected]

@estesp estesp changed the title Use default UNIX env when image has no environment [release/1.2] cherry-pick: Use default UNIX env when image has no environment Aug 29, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 29, 2019

Codecov Report

Merging #3601 into release/1.2 will increase coverage by 0.15%.
The diff coverage is 80%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.2    #3601      +/-   ##
===============================================
+ Coverage        44.09%   44.24%   +0.15%     
===============================================
  Files              100      100              
  Lines            10790    10794       +4     
===============================================
+ Hits              4758     4776      +18     
+ Misses            5293     5279      -14     
  Partials           739      739
Flag Coverage Δ
#linux 47.96% <100%> (+0.19%) ⬆️
#windows 41.09% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
oci/spec_opts.go 27.87% <80%> (+2.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783f67d...86ea2b7. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit ef264a7 into containerd:release/1.2 Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants