Skip to content

fix mis-spelling in nvidia.go#3598

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
AllenZMC:patch-1
Aug 29, 2019
Merged

fix mis-spelling in nvidia.go#3598
crosbymichael merged 1 commit intocontainerd:masterfrom
AllenZMC:patch-1

Conversation

@AllenZMC
Copy link
Copy Markdown

Make the comment more readable

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 29, 2019

Build succeeded.

@estesp
Copy link
Copy Markdown
Member

estesp commented Aug 29, 2019

Your commit failed the DCO check; please sign your commit; e.g. git commit -s --amend and force push. Thanks!

@AllenZMC
Copy link
Copy Markdown
Author

Thanks! @estesp

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 29, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3598 into master will decrease coverage by 5.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3598      +/-   ##
==========================================
- Coverage   42.27%   37.24%   -5.04%     
==========================================
  Files         126       84      -42     
  Lines       13887    11570    -2317     
==========================================
- Hits         5871     4309    -1562     
+ Misses       7130     6662     -468     
+ Partials      886      599     -287
Flag Coverage Δ
#linux ?
#windows 37.24% <ø> (+0.02%) ⬆️
Impacted Files Coverage Δ
archive/tar_opts.go 11.76% <0%> (-47.06%) ⬇️
cio/io.go 1.4% <0%> (-45.08%) ⬇️
snapshots/native/native.go 1.79% <0%> (-41.26%) ⬇️
archive/tar.go 18.95% <0%> (-29.24%) ⬇️
metadata/snapshot.go 23.86% <0%> (-24.05%) ⬇️
content/local/writer.go 57.69% <0%> (-0.97%) ⬇️
oci/spec_opts.go 28.96% <0%> (-0.24%) ⬇️
mount/temp_unix.go
sys/reaper_linux.go
services/server/server_linux.go
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36911af...f4927a2. Read the comment docs.

1 similar comment
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3598 into master will decrease coverage by 5.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3598      +/-   ##
==========================================
- Coverage   42.27%   37.24%   -5.04%     
==========================================
  Files         126       84      -42     
  Lines       13887    11570    -2317     
==========================================
- Hits         5871     4309    -1562     
+ Misses       7130     6662     -468     
+ Partials      886      599     -287
Flag Coverage Δ
#linux ?
#windows 37.24% <ø> (+0.02%) ⬆️
Impacted Files Coverage Δ
archive/tar_opts.go 11.76% <0%> (-47.06%) ⬇️
cio/io.go 1.4% <0%> (-45.08%) ⬇️
snapshots/native/native.go 1.79% <0%> (-41.26%) ⬇️
archive/tar.go 18.95% <0%> (-29.24%) ⬇️
metadata/snapshot.go 23.86% <0%> (-24.05%) ⬇️
content/local/writer.go 57.69% <0%> (-0.97%) ⬇️
oci/spec_opts.go 28.96% <0%> (-0.24%) ⬇️
mount/temp_unix.go
sys/reaper_linux.go
services/server/server_linux.go
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36911af...f4927a2. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 5a3f3e3 into containerd:master Aug 29, 2019
@AllenZMC AllenZMC deleted the patch-1 branch August 29, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants