Skip to content

fix-grammar-mistake#3590

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
tanjunchen:fix-grammar-mistake
Aug 28, 2019
Merged

fix-grammar-mistake#3590
crosbymichael merged 1 commit intocontainerd:masterfrom
tanjunchen:fix-grammar-mistake

Conversation

@tanjunchen
Copy link
Copy Markdown
Contributor

No description provided.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 28, 2019

Build succeeded.

@tanjunchen
Copy link
Copy Markdown
Contributor Author

/test continuous-integration/travis-ci/pr

@tanjunchen
Copy link
Copy Markdown
Contributor Author

@tonistiigi Hello How Should I do? Thank you !
image

@AkihiroSuda
Copy link
Copy Markdown
Member

Commit needs to be signed

Signed-off-by: chentanjun <[email protected]>
@tanjunchen
Copy link
Copy Markdown
Contributor Author

@AkihiroSuda That is right . Thanks

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 28, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 28, 2019

Codecov Report

Merging #3590 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3590   +/-   ##
=======================================
  Coverage   42.26%   42.26%           
=======================================
  Files         126      126           
  Lines       13881    13881           
=======================================
  Hits         5867     5867           
  Misses       7128     7128           
  Partials      886      886
Flag Coverage Δ
#linux 45.75% <ø> (ø) ⬆️
#windows 37.23% <ø> (ø) ⬆️
Impacted Files Coverage Δ
log/context.go 37.5% <ø> (ø) ⬆️
platforms/platforms.go 79.34% <ø> (ø) ⬆️
oci/spec_opts.go 29.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3096178...92a5b08. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit d177ffd into containerd:master Aug 28, 2019
@tanjunchen tanjunchen deleted the fix-grammar-mistake branch August 31, 2019 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants