archive: truncate modification time#3589
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Aug 28, 2019
Merged
Conversation
Signed-off-by: Tonis Tiigi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3589 +/- ##
==========================================
+ Coverage 42.26% 42.27% +0.01%
==========================================
Files 126 126
Lines 13881 13887 +6
==========================================
+ Hits 5867 5871 +4
- Misses 7128 7130 +2
Partials 886 886
Continue to review full report at Codecov.
|
|
Build succeeded.
|
dmcgowan
approved these changes
Aug 28, 2019
Member
dmcgowan
left a comment
dmcgowan
left a comment
There was a problem hiding this comment.
LGTM
We can probably add some options here in the future to make it more configurable to support nanosecond inclusion.
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes moby/buildkit#1153
Currently differ rounds timestamps, causing issues and incompatibility with previous differ when timestamps are rounded up.
In the future, the best solution should be to always force
PAXheaders and add nanoseconds into the tar but wanted to just fix the issue with this PR without introducing new changes.AccessTime/ChangeTime are also cleared to match the docker differ.
Signed-off-by: Tonis Tiigi [email protected]