Export shim publisher functions #3588
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Aug 28, 2019
Merged
Conversation
- Our out of tree shim would like to publish events with ttrpc. These functions should be exposed so our shim doesn't need to reimplement publisher logic. Signed-off-by: Kathryn Baldauf <[email protected]>
Author
Codecov Report
@@ Coverage Diff @@
## master #3588 +/- ##
=======================================
Coverage 42.26% 42.26%
=======================================
Files 126 126
Lines 13881 13881
=======================================
Hits 5867 5867
Misses 7128 7128
Partials 886 886
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3588 +/- ##
=======================================
Coverage 42.26% 42.26%
=======================================
Files 126 126
Lines 13881 13881
=======================================
Hits 5867 5867
Misses 7128 7128
Partials 886 886
Continue to review full report at Codecov.
|
|
Build succeeded.
|
AkihiroSuda
approved these changes
Aug 28, 2019
Member
|
LGTM |
Contributor
|
@katiewasnothere - Epic! Nice work finding this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
functions should be exposed so our shim doesn't need to reimplement
publisher logic.
Signed-off-by: Kathryn Baldauf [email protected]