WithImageName container opt#3584
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Aug 26, 2019
Merged
Conversation
Signed-off-by: Evan Hazlett <[email protected]>
|
Build succeeded.
|
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #3584 +/- ##
==========================================
- Coverage 42.26% 37.23% -5.04%
==========================================
Files 126 84 -42
Lines 13881 11564 -2317
==========================================
- Hits 5867 4306 -1561
+ Misses 7128 6658 -470
+ Partials 886 600 -286
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a NewContainerOpt for setting the container image name without an
Image(as inWithImage).