rootfs: use new ctx to cleanup instead of canceled one#3582
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Aug 27, 2019
Merged
rootfs: use new ctx to cleanup instead of canceled one#3582crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
|
Build succeeded.
|
Member
There was a problem hiding this comment.
instead of todo, what about context.Background()? todo seems like there is still more work to be done
Member
Author
There was a problem hiding this comment.
updated. I was thinking the todo has short name lol
Codecov Report
@@ Coverage Diff @@
## master #3582 +/- ##
=======================================
Coverage 42.26% 42.26%
=======================================
Files 126 126
Lines 13881 13881
=======================================
Hits 5867 5867
Misses 7128 7128
Partials 886 886
Continue to review full report at Codecov.
|
rootfs.CreateDiff might be canceled by context for some reason. Based on this case, the defer function should use the new ctx to do cleanup temporary snapshotter instead of the canceled one. Signed-off-by: Wei Fu <[email protected]>
fuweid
force-pushed
the
me-cleanup-issue-CreateDiff
branch
from
d46921a to
09b184c
Compare
|
Build succeeded.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rootfs.CreateDiff might be canceled by context for some reason. Based on
this case, the defer function should use the new ctx to do cleanup
temporary snapshotter instead of the canceled one.
Signed-off-by: Wei Fu [email protected]