Skip to content

update the max if cur will be greater than max for setting the limit#3578

Merged
estesp merged 1 commit intocontainerd:masterfrom
sofat1989:containerd-stress
Aug 26, 2019
Merged

update the max if cur will be greater than max for setting the limit#3578
estesp merged 1 commit intocontainerd:masterfrom
sofat1989:containerd-stress

Conversation

@sofat1989
Copy link
Copy Markdown

When we ran the containerd-stress command, we met that

panic: invalid argument

goroutine 1 [running]:
main.init.0()
	/home/fesu/go/src/github.com/containerd/containerd/cmd/containerd-stress/main.go:59 +0x4aa

In our os, the value of nofile is

RESOURCE   DESCRIPTION                             SOFT      HARD UNITS
NOFILE     max number of open files                1024      4096

It will cause EINVAL error if we set soft value is 100000 and keep the hard value is 4096

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 26, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3578 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3578   +/-   ##
=======================================
  Coverage   42.26%   42.26%           
=======================================
  Files         126      126           
  Lines       13881    13881           
=======================================
  Hits         5867     5867           
  Misses       7128     7128           
  Partials      886      886
Flag Coverage Δ
#linux 45.75% <ø> (ø) ⬆️
#windows 37.23% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a2f61c...5cab0d3. Read the comment docs.

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 3ad49a2 into containerd:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants