[carry #3127] Update pull default to skip all platform manifests#3577
Merged
crosbymichael merged 3 commits intocontainerd:masterfrom Aug 26, 2019
Merged
Conversation
- Add `all-manifests` option to both `ctr content fetch` and `ctr images pull`. By default it is false. - This option ties to `AppendDistributionSourceLabel` in client. Signed-off-by: Yu Yi <[email protected]>
Signed-off-by: Yu Yi <[email protected]>
|
Build succeeded.
|
Member
|
looks like |
dmcgowan
force-pushed
the
change-default-manifest-download
branch
from
f2e991b to
48f880f
Compare
|
Build succeeded.
|
Add flags to pull and fetch to grab all metadata. Add fetch option to pull only metadata. Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
change-default-manifest-download
branch
from
48f880f to
a40c383
Compare
|
Build succeeded.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the behavior which by default pulled all manifests and configs. Adds options to include all the metadata and a flag on fetch to only get metadata.
Also removes the option to add the distribution metadata so that it is always set. If clients have a need for removing this metadata in the future, the option can be revisited. Metadata which does not require an extra requests to the registry should not be thrown away.
Carry #3127
Fixes #3126