Pass ttrpc address to shim via env#3573
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Aug 22, 2019
Merged
Conversation
|
Build succeeded.
|
Because of the way go handles flags, passing a flag that is not defined will cause an error. In our case, if we kept this as a flag, then third-party shims would break when they see this new flag. To fix this, I moved this new configuration option to an env var. We should use env vars from here on out to avoid breaking shim compat. Signed-off-by: Michael Crosby <[email protected]>
crosbymichael
force-pushed
the
ttrpc-env
branch
from
b0979a4 to
6cf031e
Compare
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3573 +/- ##
==========================================
- Coverage 42.27% 42.26% -0.02%
==========================================
Files 126 126
Lines 13877 13881 +4
==========================================
Hits 5867 5867
- Misses 7124 7128 +4
Partials 886 886
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3573 +/- ##
==========================================
- Coverage 42.27% 42.26% -0.02%
==========================================
Files 126 126
Lines 13877 13881 +4
==========================================
Hits 5867 5867
- Misses 7124 7128 +4
Partials 886 886
Continue to review full report at Codecov.
|
Member
Author
|
@dmcgowan fixed it |
Contributor
|
Wahoo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the way go handles flags, passing a flag that is not defined
will cause an error. In our case, if we kept this as a flag, then
third-party shims would break when they see this new flag. To fix this,
I moved this new configuration option to an env var. We should use env
vars from here on out to avoid breaking shim compat.
Signed-off-by: Michael Crosby [email protected]