Skip to content

Cleanup: fix some typos in code comment#3571

Merged
fuweid merged 1 commit intocontainerd:masterfrom
beautytiger:typo-terminator
Aug 22, 2019
Merged

Cleanup: fix some typos in code comment#3571
fuweid merged 1 commit intocontainerd:masterfrom
beautytiger:typo-terminator

Conversation

@beautytiger
Copy link
Copy Markdown

Signed-off-by: Guangming Wang [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 22, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3571 into master will decrease coverage by 5.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3571      +/-   ##
==========================================
- Coverage   42.29%   37.26%   -5.03%     
==========================================
  Files         126       84      -42     
  Lines       13871    11554    -2317     
==========================================
- Hits         5867     4306    -1561     
+ Misses       7118     6648     -470     
+ Partials      886      600     -286
Flag Coverage Δ
#linux ?
#windows 37.26% <ø> (ø) ⬆️
Impacted Files Coverage Δ
events/exchange/exchange.go 68.91% <ø> (ø) ⬆️
archive/tar_opts.go 11.76% <0%> (-47.06%) ⬇️
cio/io.go 1.4% <0%> (-45.08%) ⬇️
snapshots/native/native.go 1.79% <0%> (-41.26%) ⬇️
archive/tar.go 19.18% <0%> (-28.78%) ⬇️
metadata/snapshot.go 23.86% <0%> (-24.05%) ⬇️
content/local/writer.go 57.69% <0%> (-0.97%) ⬇️
gc/scheduler/scheduler.go 66.34% <0%> (-0.97%) ⬇️
oci/spec_opts.go 28.96% <0%> (-0.24%) ⬇️
mount/temp_unix.go
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd46ea5...89eae64. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 8333d98 into containerd:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants