Skip to content

Read trailing data on apply#3570

Merged
estesp merged 1 commit intocontainerd:masterfrom
dmcgowan:fix-apply-trailing-data
Aug 21, 2019
Merged

Read trailing data on apply#3570
estesp merged 1 commit intocontainerd:masterfrom
dmcgowan:fix-apply-trailing-data

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

This was removed by mistake during the direct unpack PR refactoring.

Test needed, but this fixes a pull regression

Closes #3569

This was removed by mistake during the direct unpack
PR refactoring.

Signed-off-by: Derek McGowan <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Aug 21, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3570 into master will decrease coverage by 5.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3570      +/-   ##
==========================================
- Coverage    42.3%   37.26%   -5.04%     
==========================================
  Files         126       84      -42     
  Lines       13869    11554    -2315     
==========================================
- Hits         5867     4306    -1561     
+ Misses       7116     6648     -468     
+ Partials      886      600     -286
Flag Coverage Δ
#linux ?
#windows 37.26% <ø> (ø) ⬆️
Impacted Files Coverage Δ
archive/tar_opts.go 11.76% <0%> (-47.06%) ⬇️
cio/io.go 1.4% <0%> (-45.08%) ⬇️
snapshots/native/native.go 1.79% <0%> (-41.26%) ⬇️
archive/tar.go 19.18% <0%> (-28.78%) ⬇️
metadata/snapshot.go 23.86% <0%> (-24.05%) ⬇️
content/local/writer.go 57.69% <0%> (-0.97%) ⬇️
gc/scheduler/scheduler.go 66.34% <0%> (-0.97%) ⬇️
oci/spec_opts.go 28.96% <0%> (-0.24%) ⬇️
mount/temp_unix.go
sys/reaper_linux.go
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4924bcb...550518a. Read the comment docs.

@ehazlett
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit bd46ea5 into containerd:master Aug 21, 2019
@Random-Liu
Copy link
Copy Markdown
Member

Thanks!

@dmcgowan dmcgowan deleted the fix-apply-trailing-data branch September 10, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Direct Unpack breaks Kubernetes containerd test.

5 participants