devmapper: activate dm device if snap device marked as activated#3567
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Aug 30, 2019
Merged
devmapper: activate dm device if snap device marked as activated#3567crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
Author
|
Build succeeded.
|
mxpv
reviewed
Aug 21, 2019
renzhengeek
force-pushed
the
renzhen/devmapper
branch
from
0cbc467 to
4911d75
Compare
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3567 +/- ##
==========================================
- Coverage 42.26% 42.25% -0.02%
==========================================
Files 126 126
Lines 13881 13890 +9
==========================================
+ Hits 5867 5869 +2
- Misses 7128 7135 +7
Partials 886 886
Continue to review full report at Codecov.
|
mxpv
approved these changes
Aug 22, 2019
Member
mxpv
left a comment
mxpv
left a comment
There was a problem hiding this comment.
One minor suggestion, otherwise LGTM.
- reproducer
1. stop a container;
2. reboot, or dmsetup remove its corresponding dm device;
3. start the container, it will fail like:
"""
Error: failed to start containers: {"message":"failed to create container(4f33d2760760c41518a84821153ccdf7f80980b797b783cdd75178fc6ca0bf4b) on containerd: failed to create task for container(4f33d2760760c41518a84821153ccdf7f80980b797b783cdd75178fc6ca0bf4b): failed to mount rootfs component &{ext4 /dev/mapper/vg0-mythinpool-snap-2 []}: no such file or directory: unknown"}
"""
- how the fix works
activate the dm device if necessary, and give a warn msg:
"""
time="2019-08-21T22:44:08.422695797+08:00" level=warning msg="devmapper device \"vg0-mythinpool-snap-2\" marked as \"Activated\" but not active, activating it"
"""
Signed-off-by: Eric Ren <[email protected]>
renzhengeek
force-pushed
the
renzhen/devmapper
branch
from
4911d75 to
4d11bb3
Compare
|
Build succeeded.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"""
Error: failed to start containers: {"message":"failed to create container(4f33d2760760c41518a84821153ccdf7f80980b797b783cdd75178fc6ca0bf4b) on containerd: failed to create task for container(4f33d2760760c41518a84821153ccdf7f80980b797b783cdd75178fc6ca0bf4b): failed to mount rootfs component &{ext4 /dev/mapper/vg0-mythinpool-snap-2 []}: no such file or directory: unknown"}
"""
activate the dm device if necessary, and give a warn msg:
"""
time="2019-08-21T22:44:08.422695797+08:00" level=warning msg="devmapper device "vg0-mythinpool-snap-2" marked as "Activated" but not active, activating it"
"""
Signed-off-by: Eric Ren [email protected]