Shim hung 1.2 [backport from master]#3561
Merged
estesp merged 5 commits intocontainerd:release/1.2from Aug 20, 2019
keloyang:shim-hung-1.2
Merged
Shim hung 1.2 [backport from master]#3561estesp merged 5 commits intocontainerd:release/1.2from keloyang:shim-hung-1.2
estesp merged 5 commits intocontainerd:release/1.2from
keloyang:shim-hung-1.2
Conversation
shim.Reap and shim.Default.Wait may deadlock, use Monitor.Notify to fix this issue. Signed-off-by: Shukui Yang <[email protected]>
Signed-off-by: Michael Crosby <[email protected]> Signed-off-by: Shukui Yang <[email protected]>
Signed-off-by: Michael Crosby <[email protected]> Signed-off-by: Shukui Yang <[email protected]>
Signed-off-by: Michael Crosby <[email protected]> Signed-off-by: Shukui Yang <[email protected]>
Shim use non-blocking send now, there is no need to set bufferSize to 2048, it's a waste. Signed-off-by: Shukui Yang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release/1.2 #3561 +/- ##
===============================================
+ Coverage 43.96% 44.11% +0.14%
===============================================
Files 101 100 -1
Lines 10824 10788 -36
===============================================
Hits 4759 4759
+ Misses 5326 5290 -36
Partials 739 739
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## release/1.2 #3561 +/- ##
===============================================
+ Coverage 43.96% 44.11% +0.14%
===============================================
Files 101 100 -1
Lines 10824 10788 -36
===============================================
Hits 4759 4759
+ Misses 5326 5290 -36
Partials 739 739
Continue to review full report at Codecov.
|
Member
|
LGTM |
This was referenced Oct 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3540 also exists in branch release/1.x, this pr will backport the commits to release/1.2.