Change bufferSize back to 32#3560
Merged
fuweid merged 1 commit intocontainerd:masterfrom Aug 20, 2019
keloyang:buffersize-32
Merged
Change bufferSize back to 32#3560fuweid merged 1 commit intocontainerd:masterfrom keloyang:buffersize-32
fuweid merged 1 commit intocontainerd:masterfrom
keloyang:buffersize-32
Conversation
Shim use non-blocking send now, there is no need to set bufferSize to 2048, it's a waste. Signed-off-by: Shukui Yang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3560 +/- ##
======================================
Coverage 42.3% 42.3%
======================================
Files 126 126
Lines 13869 13869
======================================
Hits 5867 5867
Misses 7116 7116
Partials 886 886
Continue to review full report at Codecov.
|
Member
|
LGTM |
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shim use non-blocking send now, there is no need to set bufferSize to 2048,
it's a waste.
link to #3540
Signed-off-by: Shukui Yang [email protected]