Remove Windows EventLog logging hook#3550
Conversation
EventLog is very old and provides a poor experience. We have supported ETW for logging for a while, which is much better. We have also observed an issue where EventLog keeps containerd.exe open, preventing containerd from being upgraded to a new version. Due to all of this, it makes sense to remove the old EventLog hook in favor of using ETW logging on Windows as the primary diagnostic experience. Signed-off-by: Kevin Parsons <[email protected]>
|
@jterry75 PTAL |
|
Build succeeded.
|
Signed-off-by: Kevin Parsons <[email protected]>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3550 +/- ##
======================================
Coverage 42.2% 42.2%
======================================
Files 127 127
Lines 13903 13903
======================================
Hits 5868 5868
Misses 7149 7149
Partials 886 886
Continue to review full report at Codecov.
|
|
@kevpar I was just looking at the equivalent code in moby/moby; wondering: was there an associated PR to replace this with ETW logging (for the daemon)? Trying to clean up some old bits (and as the code in containerd was copied from moby, perhaps I can do the same there 😅) |
Yes, we added a logrus hook in both containerd and moby to log to ETW: |
|
Ah! It was already there; thanks for finding that! Looks like I should be able to do the same on the Moby side 🎉 |
|
You may not want to for Moby. ETW is superior 100% agree, but you need to have a session for listening to the provider guid. I'm not sure that everyone will set this up so default logs in event log may be better? |
5 participants
EventLog is very old and provides a poor experience. We have supported
ETW for logging for a while, which is much better. We have also
observed an issue where EventLog keeps containerd.exe open, preventing
containerd from being upgraded to a new version. Due to all of this,
it makes sense to remove the old EventLog hook in favor of using ETW
logging on Windows as the primary diagnostic experience.
Signed-off-by: Kevin Parsons [email protected]